update SDK to call version directly#5145
Open
codeboten wants to merge 7 commits intoopen-telemetry:mainfrom
Open
update SDK to call version directly#5145codeboten wants to merge 7 commits intoopen-telemetry:mainfrom
codeboten wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
Removing the call to version in the resource to reduce the amount of libraries imported. ~17–27% memory reduction across all scenarios ~11–23% startup time reduction Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
herin049
requested changes
Apr 27, 2026
| logger.exception( | ||
| "Failed to load resource detector '%s', skipping", | ||
| resource_detector, | ||
| extra_detector_names: Set[str] = { |
Contributor
There was a problem hiding this comment.
The usage of set here introduces non-determinism in the ordering of resource detectors.
| if "*" in extra_detector_names: | ||
| # Expand wildcard to all registered detectors except "otel" (already added) | ||
| extra_detector_names = ( | ||
| set(entry_points(group="opentelemetry_resource_detector").names) # type: ignore[reportUnknownArgumentType] |
Contributor
There was a problem hiding this comment.
Same here with the usage of set.
| # "otel" is always included and resolves to OTELResourceDetector (defined in | ||
| # this module), so we instantiate it directly to avoid an entry_points scan | ||
| # in the common case where no extra detectors are configured. | ||
| resource_detectors: List[ResourceDetector] = [OTELResourceDetector()] |
Contributor
There was a problem hiding this comment.
Fyi, the OTELResourceDetector should be merged last, not first.
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Contributor
|
Thanks for the updates! One more small comment is that the previous behavior was to allow modifying the merge order of the "otel" resource detector by respecting its position in the resource detectors list if it is explicitly provided. This is a pretty fringe use-case, but I'd prefer to keep this behavior if possible. |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…to method Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Contributor
Author
|
@herin049 i think i've addressed all your comments, please take a look |
ocelotl
reviewed
Apr 30, 2026
| ) | ||
| ) | ||
|
|
||
| if "otel" not in detector_names: |
Contributor
There was a problem hiding this comment.
Tiny suggestion, this is not needed if:
In [31]: list(dict.fromkeys([name.strip() for name in "a,c,otel,a,b".split(",") if name.strip()] + ["otel"]))
Out[31]: ['a', 'c', 'otel', 'b']
In [32]: list(dict.fromkeys([name.strip() for name in "a,c,a,b".split(",") if name.strip()] + ["otel"]))
Out[32]: ['a', 'c', 'b', 'otel']
ocelotl
reviewed
Apr 30, 2026
| ) | ||
|
|
||
| if "*" in detector_names: | ||
| registered = sorted( |
Contributor
There was a problem hiding this comment.
Does it make sense to sort them? Order should not be deterministic here in my opinion since the only criteria for ordeing is their name.
herin049
approved these changes
Apr 30, 2026
Comment on lines
+509
to
+522
| if "*" in detector_names: | ||
| registered = sorted( | ||
| name | ||
| for name in entry_points( | ||
| group="opentelemetry_resource_detector" | ||
| ).names # type: ignore[reportUnknownArgumentType] | ||
| if name != "otel" | ||
| ) | ||
| existing = set(detector_names) - {"*"} | ||
| expansion = [n for n in registered if n not in existing] | ||
| idx = detector_names.index("*") | ||
| detector_names = ( | ||
| detector_names[:idx] + expansion + detector_names[idx + 1 :] | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| if "*" in detector_names: | |
| registered = sorted( | |
| name | |
| for name in entry_points( | |
| group="opentelemetry_resource_detector" | |
| ).names # type: ignore[reportUnknownArgumentType] | |
| if name != "otel" | |
| ) | |
| existing = set(detector_names) - {"*"} | |
| expansion = [n for n in registered if n not in existing] | |
| idx = detector_names.index("*") | |
| detector_names = ( | |
| detector_names[:idx] + expansion + detector_names[idx + 1 :] | |
| ) | |
| if "*" in detector_names: | |
| registered = set( | |
| name | |
| for name in entry_points( | |
| group="opentelemetry_resource_detector" | |
| ).names # type: ignore[reportUnknownArgumentType] | |
| if name != "otel" | |
| ) | |
| expansion = sorted(registered - set(detector_names)) | |
| idx = detector_names.index("*") | |
| detector_names = ( | |
| detector_names[:idx] + expansion + detector_names[idx + 1 :] | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing the call to version in the resource to reduce the amount of libraries imported.
~17–27% memory reduction across all scenarios
~11–23% startup time reduction
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: